Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cap annotation sample for sideeffects examples #31

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

marianfoo
Copy link
Contributor

A sample for the CAP Annotation is missing in this examples.

In general the formatting with:
> >
is a bit strange.
Is this intentional?

@KvM2
Copy link
Contributor

KvM2 commented Jan 25, 2023

Hi @marianfoo , thanks for your contribution. We appreciate it and will look into this.

@JannaLisa
Copy link
Contributor

Hi @marianfoo ,
Sorry for not responding sooner, and actually at the moment I can also only tell you that this is still work in progress.
We will try to update this next week and get back to you.

@mishuagrawal
Copy link
Contributor

Hello,

Please accept my sincere apologies for responding late. Kindly note that we have now addressed your concern. We have added the missing CAP CDS annotation to our document. It should start reflecting post our next release date.

I will be closing this issue now. However, if you have any other concerns, please feel free to write back to us.

Thanks and regards,
Mishu Agrawal

@marianfoo
Copy link
Contributor Author

Thanks Mishu!

@mishuagrawal mishuagrawal reopened this Jun 28, 2023
@mishuagrawal mishuagrawal merged commit 8a0527e into SAP-docs:main Jun 28, 2023
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Jun 28, 2023
@OlMue OlMue added the type/examples-samples Related to existing examples/samples, or request for new examples/samples. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution SAP Fiori elements type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants