Src route was incorrect and breaks the tests

[stefanopassaro]

No description provided.

[cla-assistant]

All committers have signed the CLA.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[flovogt]

Hi @stefanopassaro, thanks a lot for creating this PR. Can you explain more detailed in which scenario the tests are breaking on your side, please? I am not able to reproduce the failure. For me the tests run successfully locally and in the demokit.

[stefanopassaro]

Hi! The code on github is fine. But there is a difference in the code snippet of the documentation that breaks the code if it's copy pasted (you can check by comparing the code on github and the documentation). My fix was on the docs, not the actual code. Warm regards and happy new year! Enviado desde Outlook para Android<https://aka.ms/AAb9ysg>

…

________________________________ De: Florian Vogt ***@***.***> Enviado: lunes, diciembre 30, 2024 9:42:10 a. m. Para: SAP-docs/sapui5 ***@***.***> CC: Passaro, Stefano ***@***.***>; Mention ***@***.***> Asunto: Re: [SAP-docs/sapui5] Src route was incorrect and breaks the tests (PR #174) CIBERSEGURIDAD NATURGY - Este es un CORREO EXTERNO: Verifique remitente antes de abrir adjuntos o acceder a links Hi @stefanopassaro<https://clicktime.symantec.com/15wPe67qz89GAFTdxhqhg?h=wYfE4CF8n288TFnz6h24g-YT2NgAJwL5WD27aGOHviY=&u=https://github.com/stefanopassaro>, thanks a lot for creating this PR. Can you explain little bit more detailed in which scenario the tests are breaking on your side? I am not able to reproduce the failure. For me the tests run successfully locally and in the demokit. — Reply to this email directly, view it on GitHub<https://clicktime.symantec.com/15wPURjH4tn5LMonsb3QS?h=Rj2RSmudphU9kVZh4GUZ9jInSuuKUuzU6eIqqqelpZU=&u=https://github.com/SAP-docs/sapui5/pull/174%23issuecomment-2565178370>, or unsubscribe<https://clicktime.symantec.com/15wPZFvZXWTfkJdiR9SZ4?h=-7_-F2gkIcZGK1F3VIoigWRtfTBrVYOinOzZH3vU_S0=&u=https://github.com/notifications/unsubscribe-auth/A432LALHH66TT2R5VI3BHYD2IEBNVAVCNFSM6AAAAABUKWMO5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGE3TQMZXGA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[flovogt]

The code stored in the openui5 repo differs from the one here in the documentation. The reason is that the code in openui5 has to work when developing openui5 code locally and in the UI5 Demo Kit itself, where the UI5 Runtime is located on a different location compared to the scenario where you implement an application standalone. The UI5 Demo Kit rewrites these URLs when the application is downloaded.

If we have missed any scenario / application to work locally or in the UI5 Demo Kit, feel free to report it with a step-by-step guide.

Happy new year and all the best.

[stefanopassaro]

Ok Just to point out that I'm following the step by step js walkthrough in vscode. Everything is fine except that particular snippet that breaks the code. When i run into the issue, i search the original repo, copy pasted the src route and everything worked. Maybe it's because i'm using vscode instead of BAS? Cheers S. Enviado desde Outlook para Android<https://aka.ms/AAb9ysg>

…

________________________________ De: Florian Vogt ***@***.***> Enviado: lunes, diciembre 30, 2024 10:19:52 a. m. Para: SAP-docs/sapui5 ***@***.***> CC: Passaro, Stefano ***@***.***>; Mention ***@***.***> Asunto: Re: [SAP-docs/sapui5] Src route was incorrect and breaks the tests (PR #174) CIBERSEGURIDAD NATURGY - Este es un CORREO EXTERNO: Verifique remitente antes de abrir adjuntos o acceder a links The code stored in the openui5 repo differs from the one here in the documentation. The reason is that the code in openui5 has to work when developing openui5 code locally and in the UI5 Demo Kit itself, where the UI5 Runtime is located on a different location compared to the scenario where you implement an application standalone. The UI5 Demo Kit rewrites these URLs when the application is downloaded. If we have missed any scenario / application to work locally or in the UI5 Demo Kit, feel free to report it with a step-by-step guide. Happy new year and all the best. — Reply to this email directly, view it on GitHub<https://clicktime.symantec.com/15w29hve6BTb5T7aG9WHc?h=DeWsIl_95X6lhUPrUG20CZCXPBuulbfWjEF6pV02RVg=&u=https://github.com/SAP-docs/sapui5/pull/174%23issuecomment-2565225238>, or unsubscribe<https://clicktime.symantec.com/15w2EY7vYo9BVPwVohuSE?h=_vwziLLkrNBhVpD6PsN04ytxSjby21f9w8yJ4qTw3Qc=&u=https://github.com/notifications/unsubscribe-auth/A432LAKRIIQVLTRLK7AH4IT2IEF3BAVCNFSM6AAAAABUKWMO5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGIZDKMRTHA>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[flovogt]

Thats strange.

1. Open https://sdk.openui5.org/entity/sap.m.tutorial.walkthrough/sample/sap.m.tutorial.walkthrough.27
2. Click on the "Download" button in the upper right corner
3. Unzip the project
4. Execute "npm install"
5. Execute "npm start", your browser will open "http://localhost:8080/test/mockServer.html"
6. Open "http://localhost:8080/test/testsuite.qunit.html"
7. Click on "unit/unitTests"
8. A new browser tab will be opened and the test is executed successfully

The code is exactly the same as written in the tutorial. I can only image that you serve locally the UI5 runtime on a different URL than the application.

[stefanopassaro]

Hi Florian I’ve tried and this works. But again, this is the correct version: ***@***.*** Not the one documented in the tutorial: ***@***.*** My correction was pointing to the code documentation, not the code itself which works fine. Hope it’s clear Warm regards S. De: Florian Vogt ***@***.***> Enviado el: lunes, 30 de diciembre de 2024 11:21 Para: SAP-docs/sapui5 ***@***.***> CC: Passaro, Stefano ***@***.***>; Mention ***@***.***> Asunto: Re: [SAP-docs/sapui5] Src route was incorrect and breaks the tests (PR #174) CIBERSEGURIDAD NATURGY - Este es un CORREO EXTERNO: Verifique remitente antes de abrir adjuntos o acceder a links Thats strange. 1. Open https://sdk.openui5.org/entity/sap.m.tutorial.walkthrough/sample/sap.m.tutorial.walkthrough.27<https://clicktime.symantec.com/15wPe67sHndjNzn6Haw2D?h=HjDifEooYb6lo47OUX-PS42t-G8o4tLZRGUppErwa8w=&u=https://sdk.openui5.org/entity/sap.m.tutorial.walkthrough/sample/sap.m.tutorial.walkthrough.27> 2. Click on the "Download" button in the upper right corner 3. Unzip the project 4. Execute "npm install" 5. Execute "npm start", your browser will open "http://localhost:8080/test/mockServer.html" 6. Open "http://localhost:8080/test/testsuite.qunit.html" 7. Click on "unit/unitTests" 8. A new browser tab will be opened and the test is executed successfully The code is exactly the same as written in the tutorial. I can only image that you serve locally the UI5 runtime on a different URL than the application. — Reply to this email directly, view it on GitHub<https://clicktime.symantec.com/15wPURjJNZGYZ78FCU8iy?h=XZG6nYnMoD2qWhM-5QTojh2B0UNs-E5iv7_BPTj4-4Q=&u=https://github.com/SAP-docs/sapui5/pull/174%23issuecomment-2565286352>, or unsubscribe<https://clicktime.symantec.com/15wPZFvaqAx8y3xAk2Xsb?h=N42fL23EOGle_y37qAFtp_g8kvIxsBAQAhEX9FhEt4g=&u=https://github.com/notifications/unsubscribe-auth/A432LAL2R67EOIAIEG6Y3QL2IENBFAVCNFSM6AAAAABUKWMO5GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGI4DMMZVGI>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[flovogt]

The code in the tutorial exactly uses src="../resources/sap/ui/test/starter/runTest.js" which is the right one to use.