Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using-global-side-effects-955ae31.md #159

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

andiblockiersystem
Copy link
Contributor

Fixed Sideeffect - missing comma

Fixed Sideeffect - missing comma
Copy link

cla-assistant bot commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Sep 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Sep 26, 2024

Hi @andiblockiersystem , thanks for your contribution! We'll look into it and get back to you.

@DivyaVD
Copy link
Contributor

DivyaVD commented Sep 30, 2024

Hello everyone,

Thanks again for your contribution. The changes are incorporated into the Using Global Side Effects topic. Your changes will be visible with the next official SAPUI5 release.

@DivyaVD DivyaVD added the contribution Valuable Contribution label Sep 30, 2024
Copy link

sap-doc-bot bot commented Sep 30, 2024

Thank you for your valuable content contribution, @andiblockiersystem! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@DivyaVD DivyaVD merged commit 7c5b95d into SAP-docs:main Sep 30, 2024
3 checks passed
@DivyaVD DivyaVD added the type/content-gaps Something essential is missing in the documentation. label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution SAP Fiori elements type/content-gaps Something essential is missing in the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants