Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update enabling-stream-support-b236d32.md #146

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

katansapdevelop
Copy link
Contributor

The current link to the CAP Documentation is broken. I have a updated with a proposed alternative

Current link to the CAP Documentation is broken. I have a updated with a proposed alternative
Copy link

cla-assistant bot commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Jul 23, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Jul 23, 2024

Hi @katansapdevelop, thanks for your contribution! We'll look into it and get back to you.

@mishuagrawal
Copy link
Contributor

Hello @katansapdevelop,

Thank you for bringing this to our notice. Please know that we have now replaced the non-working link with the correct one. However, the reflection of the change may take some time. The documentation will be updated post our current release.

If in case you have any further concerns, please do let us know. If your concern is resolved, kindly go ahead and close this request or let us know if we can do so.

Thanks and regards,
Mishu Agrawal

@mishuagrawal mishuagrawal added the type/content-gaps Something essential is missing in the documentation. label Aug 6, 2024
@mishuagrawal
Copy link
Contributor

Hello @katansapdevelop,

We have now updated the link and you can check it here: https://ui5.sap.com/1.127.0/#/topic/b236d32d48b74304887b3dd5163548c1

Kindly confirm if your concern is resolved and if we can go ahead and close this request.

Thanks and regards,
Mishu Agrawal

@katansapdevelop
Copy link
Contributor Author

Hi @mishuagrawal , I've just had a look and link is now working perfectly.
image

image

Thanks for fixing it up

@mishuagrawal
Copy link
Contributor

Hello @katansapdevelop,

Thank you for the confirmation. I am going to go ahead and close this request now. Please feel free to reach out to us if you have any further concerns in the future.

Thanks and regards,
Mishu Agrawal

@mishuagrawal mishuagrawal added contribution Valuable Contribution type/linking Something is wrong with the links. and removed type/content-gaps Something essential is missing in the documentation. labels Aug 15, 2024
Copy link

sap-doc-bot bot commented Aug 15, 2024

Thank you for your valuable content contribution, @katansapdevelop! So that we can recognize your contribution in the SAP Community, please check your SAP Community user ID (this is a number) in your personal settings page and share it with us in a reply to this comment. Make sure you just include the number in the reply.

Your user ID is displayed as follows:

Change display name for User ID N

where N is your user ID. For example, 53 is the user ID of the user 'qmacro'.

Please note that we are currently refactoring our profile and badge system on the SAP Community, and will start assigning badges again when that's complete.

@mishuagrawal mishuagrawal merged commit e252bf4 into SAP-docs:main Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution SAP Fiori elements type/linking Something is wrong with the links.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants