Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fluent Bit retry configuration #12

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

JannikBrand
Copy link
Contributor

By default Fluent Bit uses a Retry_Limit of 1.
Since senders want to ensure that telemetry data is ingested, even if the observability backend (here SAP Cloud Logging) is temporarily unavailable (e.g. due to network problems), we should recommend at least 3 retries.

By default Fluent Bit [uses](https://docs.fluentbit.io/manual/administration/scheduling-and-retries#configuring-retries) a Retry_Limit of 1.
Since senders want to ensure that telemetry data is ingested, even if the observability backend (e.g. SAP Cloud Logging) is temporarily unavailable (e.g. due to network problems), we should recommend at least 3 retries.
@keyes-bill
Copy link
Contributor

Thanks Jannik. I’ve made the changes here:
https://help.sap.com/docs/cloud-logging/sap-cloud-logging/ingest-via-json-api-endpoint?state=DRAFT

If this meets your approval I will push the changes out to PRODUCTION.

Copy link
Contributor

@keyes-bill keyes-bill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JannikBrand
Copy link
Contributor Author

Thanks! Approved from my side.

@keyes-bill
Copy link
Contributor

I have pushed the changes out into PRODUCTION. We should see them after the next build, which usually happens on Thursday evenings. Please keep your eye out for the changes here:
https://help.sap.com/docs/cloud-logging/cloud-logging/ingest-via-json-api-endpoint?version=Cloud

I'll be out of the office Thursday-Monday but I'll check when I get back on Tuesday August 27.

@keyes-bill keyes-bill merged commit 69c2b79 into SAP-docs:main Aug 20, 2024
3 checks passed
@sap-doc-bot sap-doc-bot bot added the contribution Valuable Contribution label Aug 20, 2024
@keyes-bill keyes-bill added size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution Valuable Contribution size/s Requires minimal effort to get changed. type/examples-samples Related to existing examples/samples, or request for new examples/samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants