Add more mentions of canary #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed github workflows to have "canary" in the zip files Added `App.FullAppName` in the about section, so that it's clear in there too
github-actions
bot
added
gui
This comment was marked as outdated.
This comment was marked as outdated.
…ing in FileLogTarget.cs
This comment was marked as outdated.
This comment was marked as outdated.
GabCoolDude
changed the title
…ate_macos_build_ava_headless.sh` instead of in seperate files This helps keeping things concise and should maybe work well idk
…ate_macos_build_ava_headless.sh` instead of in seperate files This helps keeping things concise and should maybe work well idk
# Conflicts: # distribution/macos/create_macos_build_ava.sh # distribution/macos/create_macos_build_headless.sh
This should make it so that macos builds compile like intended
…lso hopefully fixed headless macos artifacts just not getting published
i think i added the canary variable
|
Removed about 300 lines of code compared to previous versions of the PR. This was done by checking if the build is canary in |
GreemDev
previously requested changes
Nov 21, 2024
Idk if this broke or fixed anything but
GreemDev
approved these changes
Nov 21, 2024
Merged
GreemDev
pushed a commit
that referenced
this pull request
Dec 19, 2024
This should hopefully make it clearer whether or not you're using
canary.
Changelog:
- Changed github workflows to have "canary" in the zip files
- Added `App.FullAppName` in the about section, so that it's clear in
there too
- Changed log name for canary builds to
`Ryujinx_Canary_{version}_{DateTime.Now:yyyy-MM-dd_HH-mm-ss}.log`
(normal builds should still be
"Ryujinx_{version}_{DateTime.Now:yyyy-MM-dd_HH-mm-ss}.log)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully make it clearer whether or not you're using canary.
Changelog:
App.FullAppNamein the about section, so that it's clear in there tooRyujinx_Canary_{version}_{DateTime.Now:yyyy-MM-dd_HH-mm-ss}.log(normal builds should still be "Ryujinx_{version}_{DateTime.Now:yyyy-MM-dd_HH-mm-ss}.log)