Project ReBELL. Act I. Wonder Delta + retexture + new shaders #1012
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ОбзорДобавлены новые определения напольных плиток в файл Изменения
Стихотворение
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
size/XL
S: Untriaged
Changes: Sprites
|
RSI Diff Bot; head commit 89a8671 merging into 730265b Resources/Textures/Structures/Walls/solid.rsi
Resources/Textures/Structures/Walls/solid_diagonal.rsi
Resources/Textures/Structures/Walls/solid_rust.rsi
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Resources/Prototypes/_Backmen/Tiles/floors.yml (2)
5-10: Рассмотрите возможность улучшения визуального разнообразияВсе плитки используют одинаковую вероятность размещения вариантов (1.0). Для улучшения визуального разнообразия рекомендуется использовать разные вероятности.
placementVariants: - - 1.0 - - 1.0 - - 1.0 - - 1.0 + - 1.0 + - 0.8 + - 0.6 + - 0.4Also applies to: 23-28, 42-47, 60-65, 78-83, 96-101, 114-119, 132-137, 150-155
36-36: Исправьте форматирование файлаОбнаружены следующие проблемы форматирования:
- Лишние пробелы в строках 36 и 55
- Отсутствует перевод строки в конце файла
heatCapacity: 10000 - type: tile + type: tile heatCapacity: 10000 +Also applies to: 55-55, 162-162
🧰 Tools
🪛 yamllint (1.35.1)
[error] 36-36: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (66)
Resources/Textures/Backmen/Tiles/dark_herringbone.pngis excluded by!**/*.pngResources/Textures/Backmen/Tiles/dark_pavement.pngis excluded by!**/*.pngResources/Textures/Backmen/Tiles/dark_pavement_vertical.pngis excluded by!**/*.pngResources/Textures/Backmen/Tiles/steel_herringbone.pngis excluded by!**/*.pngResources/Textures/Backmen/Tiles/steel_pavement.pngis excluded by!**/*.pngResources/Textures/Backmen/Tiles/steel_pavement_vertical.pngis excluded by!**/*.pngResources/Textures/Backmen/Tiles/white_herringbone.pngis excluded by!**/*.pngResources/Textures/Backmen/Tiles/white_pavement.pngis excluded by!**/*.pngResources/Textures/Backmen/Tiles/white_pavement_vertical.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/full.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_construct-0.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_construct-1.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_construct-2.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_construct-3.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_construct-4.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_construct-5.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_over0.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_over1.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_over2.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_over3.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_over4.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_over5.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_over6.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/reinf_over7.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/solid0.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/solid1.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/solid2.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/solid3.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/solid4.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/solid5.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/solid6.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid.rsi/solid7.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_diagonal.rsi/state0.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_diagonal.rsi/state1.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/full.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/solid0.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/solid1.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/solid2.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/solid3.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/solid4.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/solid5.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/solid6.pngis excluded by!**/*.pngResources/Textures/Structures/Walls/solid_rust.rsi/solid7.pngis excluded by!**/*.pngResources/Textures/Tiles/dark_mono.pngis excluded by!**/*.pngResources/Textures/Tiles/dark_pavement_vertical.pngis excluded by!**/*.pngResources/Textures/Tiles/elevator_shaft.pngis excluded by!**/*.pngResources/Textures/Tiles/lino.pngis excluded by!**/*.pngResources/Textures/Tiles/metaldiamond.pngis excluded by!**/*.pngResources/Textures/Tiles/mining_floor.pngis excluded by!**/*.pngResources/Textures/Tiles/mining_floor_dark.pngis excluded by!**/*.pngResources/Textures/Tiles/mining_floor_light.pngis excluded by!**/*.pngResources/Textures/Tiles/reinforced.pngis excluded by!**/*.pngResources/Textures/Tiles/silver.pngis excluded by!**/*.pngResources/Textures/Tiles/steel.pngis excluded by!**/*.pngResources/Textures/Tiles/steel_diagonal.pngis excluded by!**/*.pngResources/Textures/Tiles/steel_diagonal_mini.pngis excluded by!**/*.pngResources/Textures/Tiles/steel_herringbone.pngis excluded by!**/*.pngResources/Textures/Tiles/steel_mono.pngis excluded by!**/*.pngResources/Textures/Tiles/steel_pavement_vertical.pngis excluded by!**/*.pngResources/Textures/Tiles/super_reinforced.pngis excluded by!**/*.pngResources/Textures/Tiles/white_mono.pngis excluded by!**/*.pngResources/Textures/Tiles/white_pavement_vertical.pngis excluded by!**/*.pngResources/Textures/Tiles/wood.pngis excluded by!**/*.pngResources/Textures/Tiles/wood_broken.pngis excluded by!**/*.pngResources/Textures/Tiles/wood_large.pngis excluded by!**/*.pngResources/Textures/Tiles/wood_tile.pngis excluded by!**/*.png
📒 Files selected for processing (1)
Resources/Prototypes/_Backmen/Tiles/floors.yml(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
Resources/Prototypes/_Backmen/Tiles/floors.yml
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 55-55: trailing spaces
(trailing-spaces)
[error] 162-162: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 300000ms (3)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Test Packaging
🔇 Additional comments (3)
Resources/Prototypes/_Backmen/Tiles/floors.yml (3)
1-162: Добавьте скриншоты измененийПоскольку PR включает визуальные изменения текстур, было бы полезно добавить скриншоты:
- До и после изменений
- Примеры использования новых текстур в игре
🧰 Tools
🪛 yamllint (1.35.1)
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 55-55: trailing spaces
(trailing-spaces)
[error] 162-162: no new line character at the end of file
(new-line-at-end-of-file)
4-4: Проверьте наличие текстурНеобходимо убедиться, что все указанные текстуры присутствуют в репозитории.
Also applies to: 22-22, 41-41, 59-59, 77-77, 95-95, 113-113, 131-131, 149-149
✅ Verification successful
Текстуры проверены - всё в порядке
Все необходимые текстуры присутствуют в директории Resources/Textures/Backmen/Tiles/.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if all referenced texture files exist for texture in dark_pavement.png dark_pavement_vertical.png dark_herringbone.png steel_herringbone.png steel_pavement.png steel_pavement_vertical.png white_herringbone.png white_pavement.png white_pavement_vertical.png; do if [ ! -f "Resources/Textures/Backmen/Tiles/$texture" ]; then echo "Missing texture: $texture" fi doneLength of output: 2642
Script:
#!/bin/bash # List all PNG files in the Backmen/Tiles directory fd -e png . Resources/Textures/Backmen/Tiles/Length of output: 597
87-89: Проверьте несоответствие в звуках шаговПлитка
FloorSteelPavementAltиспользуетFootstepFloor, в то время как все остальные плитки используютFootstepTile. Это может быть ошибкой.✅ Verification successful
Подтверждено несоответствие в звуках шагов
Проверка показала, что все остальные напольные покрытия, включая варианты стальных покрытий, используют звуковую коллекцию
FootstepTile. ИспользованиеFootstepFloorдляFloorSteelPavementAltдействительно является несоответствием, которое следует исправить для сохранения консистентности звуков в игре.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other steel pavement tiles to verify correct footstep sound rg "FloorSteelPavement[^A]" -A 10Length of output: 18407
Script:
#!/bin/bash # Search for footstep configurations in steel pavement tiles rg "FloorSteelPavement.*\n.*footstep" -A 3Length of output: 236
Script:
#!/bin/bash # Search for footstep configurations in steel pavement tiles rg -U "id: FloorSteelPavement.*?\n.*?footstep" -A 3Length of output: 53
Script:
#!/bin/bash # Examine the floor tile definitions in relevant files cat Resources/Prototypes/_Backmen/Tiles/floors.yml Resources/Prototypes/Tiles/floors.yml | rg -A 10 -B 2 "id: FloorSteelPavement"Length of output: 1142
Script:
#!/bin/bash # Search for default tile configurations and footstep sounds rg -U "parent.*tile.*\n.*footstep" Resources/Prototypes/Length of output: 58
Script:
#!/bin/bash # Search for FootstepTile usage in tile configurations rg "FootstepTile" Resources/Prototypes/Length of output: 4100
|
чтооооо очередные форк респрайты которые никто не будет поддерживать? круто блин🥞😎💪 |
|
А спрайты покажиш? Или это сюрпрайз |
There was a problem hiding this comment.
Спрайты стен слишком темные и непривычные, игроки взбунтуются когда их увидят из-за привыкания к старым (гипотеза и субъективное мнение, я бы у игроков опрос сделал)
There was a problem hiding this comment.
Спрайт тайла как бы странно это не звучало можно перепутать со стеной, лучше оставить как есть
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Описание PR
Первая часть из 3 обещанного проекта ReBELL.
Медиа
Тип PR
Изменения
🆑 trest100
Summary by CodeRabbit