pkcs5: initial crate #272
Merged
pkcs5: initial crate #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Feb 17, 2021
tarcieri
force-pushed
the
pkcs5
branch
2 times, most recently
from
6237d05 to
094765c
Compare
tarcieri
added a commit
that referenced
this pull request
Feb 18, 2021
Adds an error variant for propagating OIDs as discussed in #272. It's a little awkward for a few reasons: - There's already a unit `ErrorKind::Oid` variant. Since that's a little ambiguous, there's also a TODO to rename that variant to the more specific `ErrorKind::OidMalformed` in the next breaking release - Since `const-oid` is an optional dependency, the presence of this variant is conditional upon that feature being enabled. Fortunately the whole enum is marked `#[non_exhaustive]` (which is what even allows adding new variants in a non-breaking way), so hopefully the conditional presence of this variant won't be too problematic for downstream users The other problem is the `ObjectIdentifier` type is somewhat large. On a 64-bit machine, this increases the size of the overall `Error` type (which wraps `ErrorKind` with additional context) from 32-bytes to 64-bytes. That's not great, but probably worth it for the additional context being able to propagate an OID as an error provides.
tarcieri
added a commit
that referenced
this pull request
Feb 18, 2021
Adds an error variant for propagating OIDs as discussed in #272. It's a little awkward for a few reasons: - There's already a unit `ErrorKind::Oid` variant. Since that's a little ambiguous, there's also a TODO to rename that variant to the more specific `ErrorKind::OidMalformed` in the next breaking release - Since `const-oid` is an optional dependency, the presence of this variant is conditional upon that feature being enabled. Fortunately the whole enum is marked `#[non_exhaustive]` (which is what even allows adding new variants in a non-breaking way), so hopefully the conditional presence of this variant won't be too problematic for downstream users The other problem is the `ObjectIdentifier` type is somewhat large. On a 64-bit machine, this increases the size of the overall `Error` type (which wraps `ErrorKind` with additional context) from 32-bytes to 64-bytes. That's not great, but probably worth it for the additional context being able to propagate an OID as an error provides.
Adds an initial implementation of Public-Key Cryptography Standards (PKCS) #5: Password-Based Cryptography Specification Version 2.1 as described in RFC 8018. This implementation includes basic support for parsing `AlgorithmIdentifier`s representing supported PKCS#5 algorithms into a structured representation. The larger goal is being able to decrypt/encrypt PKCS#8's `EncryptedPrivateKeyInfo` (see #263) This PR doesn't actually include any encryption support yet: instead it implements the basic crate structure with the goal of adding encryption support in follow-up PRs. It also includes some changes to the `spki` crate to simplify parsing which should probably be separated out into their own PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an initial implementation of Public-Key Cryptography Standards (PKCS) 5: Password-Based Cryptography Specification Version 2.1 as described in RFC 8018.
This implementation includes basic support for parsing
AlgorithmIdentifiers representing supported PKCS#5 algorithms into a structured representation.The larger goal is being able to decrypt/encrypt PKCS#8's
EncryptedPrivateKeyInfo(see #263).This PR doesn't actually include any encryption support yet: instead it implements the basic crate structure with the goal of adding encryption support in follow-up PRs.
It also includes some changes to the(merged separately in #274)spkicrate to simplify parsing which should probably be separated out into their own PR