cipher: rework backend traits #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
force-pushed
the
block_backends
branch
from
7c03a13
to
534b0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
BlockBackendtraits into 4 specific traits:BlockCipherEncBackend,BlockCipherDecBackend,BlockModeEncBackend, andBlockModeDecBackend. Same forBlockClosure. This allows for cipher backends to remove awkard&mut &backendjuggling (see RustCrypto/block-ciphers#442), makes code a bit easier to read (i.e.encrypt_blocksinstead ofproc_blocks), and allows for one backend type to be used for both encryption and decryption.The
impl_simple_block_encdecmacro is removed since we now can implement the backend traits directly on cipher types, which should make implementation crates slightly easier to understand.Additionally, it moves traits to the
blockandciphermodules to reduce clutter in the crate root. Later we can add docs to each module to describe the traits in detail.