Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8
Hi there.
I implemented ed448.
Implementation and documentation are aligned with ed25519 implementation.
What I did
Issues
I don't know how to convert pkcs v1 to v2 format so I couldn't implement pkcs v2 enc/dec.
discussion
code duplication
Ed448 implementation is almost the same as Ed25519.
There is huge code duplication.
PublicKeyBytes is only the difference between Ed448 and Ed25519.
In Ed25519, the public key bytes length is 32, and type [u8; 32] supports
Default
.However, in Ed448, the public key bytes length is 57, and type [u8; 57] doesn't support
Default
.I implemented
PublicKeyBytes
as a struct in Ed448.If we integrate both formats, we would be able to implement them as a macro.
crate name
ed448 crate was already taken. I would like to know what name we should name.
Todo
I would appreciate it if you could confirm.
Thank you.