sha1: pass block slices to sha1_asm + remove cfg toggle for constants #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't really depend on RustCrypto/asm-hashes#38 but it is required to make it work for me on a M1 Mac.
As the title says i changed the (internal) API so that block slices instead of independent blocks are passes to
sha1_asm
.I also removed the
cfg
toggles foraarch64
, because they are required for the software-fallback andasm-aarch64
is marked deprecated anyway.Benchmarks on my M1 MacBookPro:
Soft
ASM