-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blake2: integrate blake2b_simd
/blake2s_simd
crates
#228
Open
tarcieri
wants to merge
14
commits into
master
Choose a base branch
from
blake2_simd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28,257
−999
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7681a7c
blake2: integrate `blake2b_simd`/`blake2s_simd` crates
tarcieri 974a482
blake2: fix clippy nits
tarcieri f386c6d
blake2: rustdoc improvements
tarcieri 02dd382
blake2: fix fuzz
tarcieri d8c8716
blake2: factors AVX2/SSE41/portable impls under `backend` module
tarcieri 49ed198
blake2: extract `Params` types into modules
tarcieri 236d6e0
blake2: extract `State` types into modules
tarcieri 0ce9be6
blake2: extract `Hash` types into modules
tarcieri 6b5baa8
blake2: switch from `constant_time_eq` to `subtle`
tarcieri 8f34bce
blake2: impl `crypto_mac` and `digest` traits
tarcieri 647fb62
blake2: re-add tests from upstream crate
tarcieri 3889d22
blake2: update `allow(clippy::ptr_offset_with_cast)` comment
tarcieri c011346
blake2: fix build + warnings on no_std targets
tarcieri 78292ec
blake2: disable tests in mod.rs for now
tarcieri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
blake2: fix clippy nits
commit 974a482ff541a85e21e615ebf3b4e243dd7968a4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oconnor663 noticing compile failures (well, more like warnings) for this and the other cases below when testing on a
thumbv7em-none-eabi
target (which is SOP for us).Is there some sort of fallback on these platforms that will avoid this panic? If not, these should probably be changed to
compile_error!
(and separately, we should address the issue before merging if so)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tarcieri are you sure you can trigger this panic in practice? If you look at how these functions are used in
compress_many
,imp.degree()
is checked first, which should prevent this panic. In particular, I expect thePortable
platform should get selected onthumbv7em-none-eabi
, which should have adegree()
of 1.