Skip to content

x509-cert: add DirectoryString::BmpString #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dishmaker
Copy link
Contributor

@dishmaker dishmaker commented May 2, 2025

@dishmaker dishmaker force-pushed the dishmaker/x509_cert_add_bmpstring branch from 25f4c88 to 3c1a63c Compare May 2, 2025 21:46
@dishmaker
Copy link
Contributor Author

Maybe let's add as_ref without trait and #[deprecate] it ?

@tarcieri
Copy link
Member

tarcieri commented May 5, 2025

@dishmaker that works

@tarcieri
Copy link
Member

tarcieri commented May 5, 2025

Maybe also add a ToString impl and a From<DirectoryString> for String impl? (you will need to silence clippy for the former IIRC)

dishmaker added 3 commits May 6, 2025 14:45
x509-cert: use alloc instead of std

x509-cert: apply clippy Cow<'_, str>

x509-cert: fix test decode_cert_bmpstring
@dishmaker dishmaker force-pushed the dishmaker/x509_cert_add_bmpstring branch from 681b6e1 to a0fb1e4 Compare May 6, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x509-cert: BMPString support for DirectoryString
2 participants