-
Notifications
You must be signed in to change notification settings - Fork 137
sm4: simd support for armv8, x86_64 #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
zonyitoo
commented
Nov 3, 2023
- x86_64: aesni, avx2
- armv8: crypto-extension, neon
Thank you! It's a relatively sizable PR, so it will take some time for us to properly review it. |
Hello @newpavlov , what do you think about this PR? |
@zonyitoo it looks pretty impressive but as @newpavlov said it is large and because of that hard to review, especially because it contains so many backends in a single PR. We're about to start making some breaking changes and I was looking through to see if we should land this PR first. I think it would probably make sense to try to land this as part of our next breaking release cycle. See #394 |
- x86_64: aesni, avx2 - armv8: crypto-extension, neon
Sorry for the very very long reply since the last review. I was waiting for the final release of |
good work ! I need this! |
@tarcieri Hello, do you have time to review (again) this PR? |
Just found that x86 also has SM4 support in its latest CPUs, but rustc's |
@zonyitoo |
Yes, I just did it in my local branch. But since this PR is already too large, I would make another one after this PR is merged.
which are rather new cpu models. I have already finished coding with the latest x86_64 sm4 extension, but have no CPU to test. QEMU doesn't support Arrow Lake currently unfortunately. |
For what it's worth, Intel SDE should support those instructions already. |