minor code tweak

RustCrypto · Feb 12, 2025 · 4bd3d51 · 4bd3d51
1 parent 923ef32
commit 4bd3d51
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/des/src/des.rs b/des/src/des.rs
@@ -53,11 +53,9 @@ impl KeyInit for Des {
 
     #[inline]
     fn weak_key_test(key: &Key<Self>) -> Result<(), WeakKeyError> {
-        let is_weak = super::weak_key_test(&key.0);
-        if is_weak == 0 {
-            Ok(())
-        } else {
-            Err(WeakKeyError)
+        match super::weak_key_test(&key.0) {
+            0 => Ok(()),
+            _ => Err(WeakKeyError),
         }
     }
 }

diff --git a/des/src/lib.rs b/des/src/lib.rs
@@ -33,11 +33,10 @@ pub use crate::tdes::{TdesEde2, TdesEde3, TdesEee2, TdesEee3};
 
 /// Checks whether the key is weak.
 ///
-/// Returns 1 if key is weak and 0 otherwise.
+/// Returns 1 if the key is weak; otherwise, returns 0.
 fn weak_key_test(key: &[u8; 8]) -> u8 {
     let key = u64::from_ne_bytes(*key);
     let mut is_weak = 0u8;
-
     for &weak_key in crate::consts::WEAK_KEYS {
         is_weak |= u8::from(key == weak_key);
     }

diff --git a/des/src/tdes.rs b/des/src/tdes.rs
@@ -25,10 +25,9 @@ fn weak_key_test(key: &[u8]) -> Result<(), WeakKeyError> {
         is_weak |= super::weak_key_test(des_key);
     }
 
-    if is_weak == 0 {
-        Ok(())
-    } else {
-        Err(WeakKeyError)
+    match is_weak {
+        0 => Ok(()),
+        _ => Err(WeakKeyError),
     }
 }