-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump bindgen. #34
Bump bindgen. #34
Conversation
r? @est31 |
cargo test passes for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Wait do you know why it's segfaulting on CI? |
Hmm, it doesn't seem to be segfaulting, but it's not finding libclang... |
Untested as I'm not on macos, but it should be behavior-identical as the only potential relevant breaking change for coreaudio is the size_t -> usize mapping, that this PR restores.
Ah, I know what's going on. This is using So to restore previous behavior we need to enable the |
CI is green now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you! Would there be a chance of getting a minor release with this change? |
Ah, you're way ahead, just saw #35 :) |
Untested as I'm not on macos, but it should be behavior-identical as the only
potential relevant breaking change for coreaudio is the size_t -> usize mapping,
that this PR restores.