Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bindgen. #34

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Bump bindgen. #34

merged 1 commit into from
Mar 10, 2020

Conversation

emilio
Copy link
Contributor

@emilio emilio commented Mar 9, 2020

Untested as I'm not on macos, but it should be behavior-identical as the only
potential relevant breaking change for coreaudio is the size_t -> usize mapping,
that this PR restores.

@emilio
Copy link
Contributor Author

emilio commented Mar 9, 2020

r? @est31

@jrmuizel
Copy link

cargo test passes for me.

Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@est31
Copy link
Member

est31 commented Mar 10, 2020

Wait do you know why it's segfaulting on CI?

@emilio
Copy link
Contributor Author

emilio commented Mar 10, 2020

Hmm, it doesn't seem to be segfaulting, but it's not finding libclang...

Untested as I'm not on macos, but it should be behavior-identical as the only
potential relevant breaking change for coreaudio is the size_t -> usize mapping,
that this PR restores.
@emilio
Copy link
Contributor Author

emilio commented Mar 10, 2020

Ah, I know what's going on. This is using default-features = false, and bindgen has static linking support now: rust-lang/rust-bindgen#1620

So to restore previous behavior we need to enable the runtime feature. Done.

@emilio
Copy link
Contributor Author

emilio commented Mar 10, 2020

CI is green now

Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@est31 est31 merged commit 5f3e12c into RustAudio:master Mar 10, 2020
@est31 est31 mentioned this pull request Mar 10, 2020
@emilio
Copy link
Contributor Author

emilio commented Mar 10, 2020

Thank you! Would there be a chance of getting a minor release with this change?

@emilio
Copy link
Contributor Author

emilio commented Mar 10, 2020

Ah, you're way ahead, just saw #35 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants