Skip to content

Fix LocaleIterator for platforms where c_char is u8 #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abnormalmaps
Copy link

The main example for this would be aarch64 Android, where the current HEAD fails to build.

@geniot
Copy link

geniot commented Apr 20, 2025

Interesting... I just had the same problem, spend a couple of hours, found the problem, fixed it and was about to create a PR when I saw this :)
Anyway my fix is about removing the usage of try_get_string altogether:

    let region = if sdl_locale.country.is_null() {
        None
    } else {
        Some(
            std::ffi::CStr::from_ptr(sdl_locale.country)
                .to_string_lossy()
                .into_owned(),
        )
    };

Btw, my target aarch64 device is TrimUI Smart Pro. What is yours?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants