Add player index functions for game controller and joystick #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobrand
reviewed
Feb 18, 2025
src/sdl2/joystick.rs
Outdated
| let player_index = unsafe { sys::SDL_JoystickGetDevicePlayerIndex(device_index) }; | ||
|
|
||
| // if index is -1, joystick has no player | ||
| if player_index == -1 { |
There was a problem hiding this comment.
If player_index returned is less than -1, you'll get a rust overflow just below. Instead of checking == -1, do < 0.
|
Sorry for the delay. Overall looks good aside from 1 comparison used twice in the code. Could you update the changelog as well please? |
…DL_JoystickGetPlayerIndex
|
I went ahead and changed the other occurrences of player index checks to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
SDL_JoystickSetPlayerIndex,SDL_JoystickGetPlayerIndex,SDL_GameControllerSetPlayerIndex,SDL_GameControllerGetPlayerIndex, andSDL_JoystickGetDevicePlayerIndex.Additionally exposes
SDL_JoystickFromPlayerIndex, andSDL_GameControllerFromPlayerIndexusing instance IDs instead of joysticks/controllers to match Controller events (unless I'm missing something, we can't get a Joystick's device index from its object, so that cannot match the corresponding event format).