add ClippingRect #1450
Merged
add ClippingRect #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobrand
reviewed
Feb 18, 2025
src/sdl2/render.rs
Outdated
| pub fn clip_rect(&self) -> ClippingRect { | ||
| let clip_enabled = unsafe { sys::SDL_RenderIsClipEnabled(self.context.raw) }; | ||
|
|
||
| if let sys::SDL_bool::SDL_FALSE = clip_enabled { |
There was a problem hiding this comment.
binding is unnecessary here, just do if sys::SDL_bool::SDL_FALSE == clip_enabled {
There was a problem hiding this comment.
fails to compile
addressed: 76a697e
|
Definitely needs a changelog entry because it breaks the API. |
@Cobrand there is a changelog entry in changelog.md. Am I missing somewhere else to put it? |
My bad I didn't see it in the initial commit, which is why I thought you didn't add one. Looks good now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in rust-sdl2, Rect can't have a zero width or height. This is instead represented with Option, where None covers this case.
The Canvas
set_clip_rectandclip_rectfunction work with Option as well. However, for those functions None instead represents the lack of a clipping rect. This is distinctly differently, as clearing the clipping rect is like setting a Rect with an infinite area, and not a zero area (which would instead disable drawing).This is value aliasing which can be corrected with a better type representation; it's impossible with current API to set a clipping rect with a zero area, which is a valid request that disables drawing. Since this has been fixed in sdl2, this MR keep in sync with upstream.
This is not backwards compatible. Thoughts?