-
Notifications
You must be signed in to change notification settings - Fork 473
Implement custom blend modes #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@@ -9,6 +9,8 @@ when upgrading from a version of rust-sdl2 to another. | |||
|
|||
[PR #1407](https://github.com/Rust-SDL2/rust-sdl2/pull/1407) Add new use_ios_framework for linking to SDL2.framework on iOS | |||
|
|||
[PR #1439](https://github.com/Rust-SDL2/rust-sdl2/pull/1439) **BREAKING CHANGE** Implement custom blend modes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be marked Maybe breaking change by the same criteria as #1156 in v0.35.0?
I don't know how you changed the sdl_bindings, but it feels like you changed them manually. At the very top of the file it says Just in case I am right and you changed the |
Is this PR inactive? I really want a Rust equivalent of the SDL_ComposeCustomBlendMode C function |
Sorry for the very slow reply. @Cobrand, you are correct, I manually edited @antonilol, technically yes. However, as is clear from this correspondence above, this PR is (at least currently) not suitable for merging. As said, I am that inexperienced with C FFI that I have to first familiarize myself better with That said, should anyone else feel like stepping up to finish this all up, feel free! |
Implements the possibility to compose custom blend modes through a builder type. Additionally removes some transmutes and unnecessary
try_from
s from conversions fromu32
toBlendMode
and cleans out some bindgen-generated related code insdl2-sys
.enum BlendMode
now has one additional variant for representing custom blend modes, which technically constitutes a breaking change, even though likely quite a marginal one in real-world use.Addresses issue #878.