WIP typecheck issues with Try #3394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we pass generic types as the Self on traits they need to be handled via a special case on fntypes, ADT's and placeholders as the type params won't necessarily match up because of the implicit Self. Fixes #3382 gcc/rust/ChangeLog: * typecheck/rust-substitution-mapper.cc (SubstMapperInternal::visit): special case gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: nr2 cant handle this * rust/compile/issue-3382.rs: New test. Signed-off-by: Philip Herron <[email protected]>
philberty
force-pushed
the
phil/try-compatible
branch
from
35bb75f to
a0e217b
Compare
philberty
changed the title
|
closing this down to open up sperate PR's for the fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we pass generic types as the Self on traits they need to be handled via a special case on fntypes, ADT's and placeholders as the type params won't necessarily match up because of the implicit Self.
Fixes #3382
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: