Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: Allow anything as a match scrutinee #3379

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

CohenArthur
Copy link
Member

This commit is required for this type of pattern, which isn't really pattern matching:

match something {
    new_binding => { ... }
}

This is required for desugaring for-loops and error propagation expressions.

@CohenArthur CohenArthur added this to the Question mark operator milestone Jan 22, 2025
gcc/rust/ChangeLog:

	* backend/rust-compile-expr.cc (check_match_scrutinee): Allow anything to be used as a
	match scrutinee, not just ADTs.
Copy link
Member

@philberty philberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the cmp.rs stuff i am doing i think its going to be time next month to rework the code-gen of math expressions anyway to do if statements potentially instead of switches like we've talked about before

@philberty philberty added the bug label Jan 23, 2025
@philberty philberty added this pull request to the merge queue Jan 23, 2025
Merged via the queue into Rust-GCC:master with commit 3638b05 Jan 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants