testsuite: Fix missing handling of little endian. #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can give you SSH to our beefy sparc machine (just email me an SSH key + desired username). It needs kicking for a reboot every so often but it's fine otherwise. It's the same machine used for the sourceware buildbot. |
|
thanks @thesamesam I appreciate it a lot :) I've tested these changes on one of the machines of the GCC compile farm but I'll definitely take you up on that offer :D I'll email you! |
CohenArthur
force-pushed
the
fix-be-testsuite-failure-issue-1446
branch
from
04907a6 to
46feb45
Compare
Closed
CohenArthur
force-pushed
the
fix-be-testsuite-failure-issue-1446
branch
from
46feb45 to
b2be198
Compare
CohenArthur
changed the title
CohenArthur
force-pushed
the
fix-be-testsuite-failure-issue-1446
branch
from
b2be198 to
09d6ad2
Compare
|
not sure why this causes a regression on MacOS. I'll ssh into the machine and investigate later |
CohenArthur
force-pushed
the
fix-be-testsuite-failure-issue-1446
branch
2 times, most recently
from
26f5bb3 to
4fdef02
Compare
Merged
CohenArthur
force-pushed
the
fix-be-testsuite-failure-issue-1446
branch
2 times, most recently
from
3bcaab0 to
492501c
Compare
Some failures occur in the testsuite because we
did not account for the little-endian case.
gcc/testsuite/ChangeLog:
* rust/compile/issue-1446.rs: Add swap_bytes function.
* rust/compile/iterators1.rs: Remove unused {to, from}_le functions.
gcc/testsuite/ChangeLog: * rust/compile/macros/builtin/eager1.rs: Switch to scan-assembler directive as the GIMPLE dump does not contain strings on LE. * rust/compile/macros/builtin/recurse2.rs: Likewise.
philberty
force-pushed
the
fix-be-testsuite-failure-issue-1446
branch
from
492501c to
65ef110
Compare
philberty
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some failures occur in the testsuite because we
did not account for the big-endian case.
gcc/testsuite/ChangeLog:
Before merging this I would like to run our testsuite on the compile farm on a SPARC machine to see that they're really fixed. Will report here once it's done.