Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: Ensure buffer allocation for bootstrap #2746

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

P-E-P
Copy link
Member

@P-E-P P-E-P commented Nov 17, 2023

Bootstrap was failing because the vector did not allocate the internal buffer and was holding a null pointer.

Commit to fixup is b71fd2a

gcc/rust/ChangeLog:

* expand/rust-proc-macro.cc (generate_proc_macro_decls_symbol): Resize the vector and initialize it with dummy data before changing it.

Bootstrap was failing because the vector did not allocate the internal
buffer and was holding a null pointer.

Commit to fixup is b71fd2a

gcc/rust/ChangeLog:

	* expand/rust-proc-macro.cc (generate_proc_macro_decls_symbol): Resize
	the vector and initialize it with dummy data before changing it.

Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
@P-E-P P-E-P added this to the GCC 14.1 release milestone Nov 17, 2023
@P-E-P P-E-P requested a review from CohenArthur November 17, 2023 14:30
@P-E-P P-E-P marked this pull request as ready for review November 17, 2023 14:30
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silly C++

@P-E-P P-E-P added this pull request to the merge queue Nov 21, 2023
Merged via the queue into Rust-GCC:master with commit 5f0e77a Nov 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants