Fix casting error behind generics #1938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goar5670
force-pushed
the
master
branch
3 times, most recently
from
b1bb4fc to
2afdec8
Compare
philberty
requested changes
Feb 28, 2023
gcc/rust/typecheck/rust-casts.cc
Outdated
| @@ -63,11 +63,11 @@ TypeCastRules::cast_rules () | |||
| from.get_ty ()->debug_str ().c_str (), | |||
| to.get_ty ()->debug_str ().c_str ()); | |||
|
|
|||
| switch (from.get_ty ()->get_kind ()) | |||
| switch (from.get_ty ()->destructure ()->get_kind ()) | |||
There was a problem hiding this comment.
I think it would be better to do something like the unify code over in rust-unify.cc UnifyRules::go
TyTy::BaseType *
UnifyRules::go ()
{
TyTy::BaseType *ltype = lhs.get_ty ();
TyTy::BaseType *rtype = rhs.get_ty ();
ltype = lhs.get_ty ()->destructure ();
rtype = rhs.get_ty ()->destructure ();
So that you only need to call it once and it doesn't get lost.
There was a problem hiding this comment.
Edited it, please take another look.
|
Just so you know i would really like to merge this soon because I want to work on #1898 tomorrow |
|
If your having problems with the git commit format checker you can run the checker locally via: |
goar5670
force-pushed
the
master
branch
3 times, most recently
from
4003c26 to
4be2d6c
Compare
gcc/rust/ChangeLog: * typecheck/rust-casts.cc (TypeCastRules::cast_rules): Perform destructure on `from` type. gcc/testsuite/ChangeLog: * rust/compile/cast_generics.rs: New test. Signed-off-by: Mahmoud Mohamed <[email protected]>
goar5670
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1897
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: