Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing .js files #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabe-terrell
Copy link

@gabe-terrell gabe-terrell commented Feb 12, 2018

These files are required for usage in swiftmetrics and the upcoming
pymetrics repo. They are copied directly from the graph_user_data branch

These files are required for usage in `swiftmetrics` and the upcoming
`pymetrics` repo.
@sjanuary
Copy link
Contributor

sjanuary commented Feb 20, 2018

envTable.js was replaced by textTable.js, which is more general but can be used to display data in exactly the same way. httpTop5.js was replaced by top5.js which I think is an exact copy. pymetrics should use these new files instead and rebase against the master branch.

See #36 for details

@sjanuary
Copy link
Contributor

FYI - SwiftMetrics moved from envTable to textTable in this PR: https://github.com/RuntimeTools/SwiftMetrics/pull/177/files. You should be able to do something similar.

@hhellyer
Copy link
Member

@gabe-terrell - I'm not sure why you picked my graph_user_data branch, it's a long way out of date. I'm not actually sure why this is on the main repository and not my clone (possibly an accidental push) - I should delete the branch.

envTable.js and httpTop5.js were refactored out some time ago. I think swiftmetrics should have been updated to use those.

Please always work off master. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants