removed unneeded 'Preview' button

RuckusWirelessIL · Dec 30, 2013 · 80f62e4 · 80f62e4
1 parent 3063d25
commit 80f62e4
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 54 deletions.
diff --git a/doc/example.png b/doc/example.png
diff --git a/src/main/java/com/ruckuswireless/pentaho/kafka/consumer/KafkaConsumerDialog.java b/src/main/java/com/ruckuswireless/pentaho/kafka/consumer/KafkaConsumerDialog.java
@@ -23,18 +23,12 @@
 import org.eclipse.swt.widgets.Text;
 import org.pentaho.di.core.Const;
 import org.pentaho.di.i18n.BaseMessages;
-import org.pentaho.di.trans.Trans;
 import org.pentaho.di.trans.TransMeta;
-import org.pentaho.di.trans.TransPreviewFactory;
 import org.pentaho.di.trans.step.BaseStepMeta;
 import org.pentaho.di.trans.step.StepDialogInterface;
-import org.pentaho.di.ui.core.dialog.EnterNumberDialog;
-import org.pentaho.di.ui.core.dialog.EnterTextDialog;
-import org.pentaho.di.ui.core.dialog.PreviewRowsDialog;
 import org.pentaho.di.ui.core.widget.ColumnInfo;
 import org.pentaho.di.ui.core.widget.TableView;
 import org.pentaho.di.ui.core.widget.TextVar;
-import org.pentaho.di.ui.trans.dialog.TransPreviewProgressDialog;
 import org.pentaho.di.ui.trans.step.BaseStepDialog;
 
 /**
@@ -191,10 +185,8 @@ public void modifyText(ModifyEvent e) {
 		wOK.setText(BaseMessages.getString("System.Button.OK")); //$NON-NLS-1$
 		wCancel = new Button(shell, SWT.PUSH);
 		wCancel.setText(BaseMessages.getString("System.Button.Cancel")); //$NON-NLS-1$
-		wPreview = new Button(shell, SWT.PUSH);
-		wPreview.setText(BaseMessages.getString("System.Button.Preview")); //$NON-NLS-1$
 
-		setButtonPositions(new Button[] { wOK, wPreview, wCancel }, margin, null);
+		setButtonPositions(new Button[] { wOK, wCancel }, margin, null);
 
 		// Kafka properties
 		ColumnInfo[] colinf = new ColumnInfo[] {
@@ -222,14 +214,8 @@ public void handleEvent(Event e) {
 				ok();
 			}
 		};
-		lsPreview = new Listener() {
-			public void handleEvent(Event e) {
-				preview();
-			}
-		};
 		wCancel.addListener(SWT.Selection, lsCancel);
 		wOK.addListener(SWT.Selection, lsOK);
-		wPreview.addListener(SWT.Selection, lsPreview);
 
 		lsDef = new SelectionAdapter() {
 			public void widgetDefaultSelected(SelectionEvent e) {
@@ -333,41 +319,4 @@ private void ok() {
 		stepname = wStepname.getText();
 		dispose();
 	}
-
-	private void preview() {
-		KafkaConsumerMeta oneMeta = new KafkaConsumerMeta();
-		setData(oneMeta);
-
-		TransMeta previewMeta = TransPreviewFactory.generatePreviewTransformation(transMeta, oneMeta,
-				wStepname.getText());
-		transMeta.getVariable("Internal.Transformation.Filename.Directory");
-		previewMeta.getVariable("Internal.Transformation.Filename.Directory");
-
-		EnterNumberDialog numberDialog = new EnterNumberDialog(shell, props.getDefaultPreviewSize(),
-				Messages.getString("KafkaConsumerDialog.PreviewSize.DialogTitle"),
-				Messages.getString("KafkaConsumerDialog.PreviewSize.DialogMessage"));
-		int previewSize = numberDialog.open();
-		if (previewSize > 0) {
-			TransPreviewProgressDialog progressDialog = new TransPreviewProgressDialog(shell, previewMeta,
-					new String[] { wStepname.getText() }, new int[] { previewSize });
-			progressDialog.open();
-
-			Trans trans = progressDialog.getTrans();
-			String loggingText = progressDialog.getLoggingText();
-
-			if (!progressDialog.isCancelled()) {
-				if (trans.getResult() != null && trans.getResult().getNrErrors() > 0) {
-					EnterTextDialog etd = new EnterTextDialog(shell,
-							Messages.getString("System.Dialog.PreviewError.Title"),
-							Messages.getString("System.Dialog.PreviewError.Message"), loggingText, true);
-					etd.setReadOnly();
-					etd.open();
-				}
-			}
-			PreviewRowsDialog prd = new PreviewRowsDialog(shell, transMeta, SWT.NONE, wStepname.getText(),
-					progressDialog.getPreviewRowsMeta(wStepname.getText()), progressDialog.getPreviewRows(wStepname
-							.getText()), loggingText);
-			prd.open();
-		}
-	}
 }
diff --git a/...in/resources/com/ruckuswireless/pentaho/kafka/consumer/messages/messages_en_US.properties b/...in/resources/com/ruckuswireless/pentaho/kafka/consumer/messages/messages_en_US.properties
@@ -11,8 +11,6 @@ KafkaConsumerDialog.TopicName.Label=Topic name
 KafkaConsumerDialog.FieldName.Label=Target field name
 KafkaConsumerDialog.Limit.Label=Messages limit
 KafkaConsumerDialog.Timeout.Label=Read timeout (in ms)
-KafkaConsumerDialog.PreviewSize.DialogTitle=Enter preview size
-KafkaConsumerDialog.PreviewSize.DialogMessage=Enter the number of rows you would like to preview\\\:
 KafkaConsumerDialog.TableView.Label=Kafka Properties
 KafkaConsumerDialog.TableView.NameCol.Label=Name
 KafkaConsumerDialog.TableView.ValueCol.Label=Value