Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MessageBoard and message_board_spec #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added MessageBoard and message_board_spec #11

wants to merge 4 commits into from

Conversation

adamxlowe
Copy link

No description provided.

@jwo
Copy link
Member

jwo commented Mar 3, 2014

If I run these specs, it fails:

  1) Conductor should tell the engineer to slow down
     Failure/Error: let(:engineer) { Engineer.new }
     ArgumentError:
       wrong number of arguments (0 for 1)
     # ./train.rb:16:in `initialize'
     # ./train_spec.rb:5:in `new'
     # ./train_spec.rb:5:in `block (2 levels) in <top (required)>'
     # ./train_spec.rb:9:in `block (2 levels) in <top (required)>'

Do they fail for you?

@adamxlowe
Copy link
Author

I added a message board spec for the changed code. I don't know why it
didn't push before.

require 'rspec'
require './train'
describe MessageBoard do

let(:message_board) { MessageBoard.new }
let(:engineer) { Engineer.new(message_board) }
let(:conductor) { Conductor.new(message_board)}

it "should tell the engineer to slow down" do
    message_board.should_receive(:slow_down!)
    conductor.see_danger_coming!
end

it "should confirm to the conductor that it slowed down" do
message_board.should_receive(:confirm_slow_down)
engineer.slowing_down!
end
end

On Mon, Mar 3, 2014 at 9:02 AM, Jesse Wolgamott [email protected]:

If I run these specs, it fails:

  1. Conductor should tell the engineer to slow down
    Failure/Error: let(:engineer) { Engineer.new }
    ArgumentError:
    wrong number of arguments (0 for 1)

    ./train.rb:16:in `initialize'

    ./train_spec.rb:5:in`new'

    ./train_spec.rb:5:in `block (2 levels) in <top (required)>'

    ./train_spec.rb:9:in`block (2 levels) in <top (required)>'

Do they fail for you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/11#issuecomment-36531782
.

@jwo
Copy link
Member

jwo commented Mar 4, 2014

so, the specs are still failing for me. Are they passing for you?

@adamxlowe
Copy link
Author

rspec message_board_spec.rb

..

Top 2 slowest examples (0.00072 seconds, 100.0% of total time):

MessageBoard should tell the engineer to slow down

0.00045 seconds ./message_board_spec.rb:9

MessageBoard should confirm to the conductor that it slowed down

0.00027 seconds ./message_board_spec.rb:14

Finished in 0.00123 seconds

2 examples, 0 failures

Randomized with seed 6127

On Tue, Mar 4, 2014 at 11:32 AM, Jesse Wolgamott
[email protected]:

so, the specs are still failing for me. Are they passing for you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/11#issuecomment-36664000
.

@jwo
Copy link
Member

jwo commented Mar 4, 2014

Hmm, but there are more spec files than the message_board_spec, right?

On Tue, Mar 4, 2014 at 2:38 PM, Adam Lowe [email protected]
wrote:

rspec message_board_spec.rb
..
Top 2 slowest examples (0.00072 seconds, 100.0% of total time):
MessageBoard should tell the engineer to slow down
0.00045 seconds ./message_board_spec.rb:9
MessageBoard should confirm to the conductor that it slowed down
0.00027 seconds ./message_board_spec.rb:14
Finished in 0.00123 seconds
2 examples, 0 failures
Randomized with seed 6127
On Tue, Mar 4, 2014 at 11:32 AM, Jesse Wolgamott
[email protected]:

so, the specs are still failing for me. Are they passing for you?

Reply to this email directly or view it on GitHubhttps://github.com//pull/11#issuecomment-36664000
.


Reply to this email directly or view it on GitHub:
#11 (comment)

@adamxlowe
Copy link
Author

That's the spec I wrote for the assignment.

On Tue, Mar 4, 2014 at 11:42 AM, Jesse Wolgamott
[email protected]:

Hmm, but there are more spec files than the message_board_spec, right?

On Tue, Mar 4, 2014 at 2:38 PM, Adam Lowe [email protected]
wrote:

rspec message_board_spec.rb
..
Top 2 slowest examples (0.00072 seconds, 100.0% of total time):
MessageBoard should tell the engineer to slow down
0.00045 seconds ./message_board_spec.rb:9
MessageBoard should confirm to the conductor that it slowed down
0.00027 seconds ./message_board_spec.rb:14
Finished in 0.00123 seconds
2 examples, 0 failures
Randomized with seed 6127
On Tue, Mar 4, 2014 at 11:32 AM, Jesse Wolgamott
[email protected]:

so, the specs are still failing for me. Are they passing for you?

Reply to this email directly or view it on GitHub<
https://github.com/RubyoffRails/train-message_expectations/pull/11#issuecomment-36664000>

.


Reply to this email directly or view it on GitHub:

#11 (comment)

Reply to this email directly or view it on GitHubhttps://github.com//pull/11#issuecomment-36665076
.

@jwo
Copy link
Member

jwo commented Mar 4, 2014

Hey Adam --

You should be running rspec . --- and if the spec files were in a spec
directory, you should run rspec spec

tl;dr: You have a failing spec, and should not.

On Tue, Mar 4, 2014 at 2:44 PM, Adam Lowe [email protected] wrote:

That's the spec I wrote for the assignment.

On Tue, Mar 4, 2014 at 11:42 AM, Jesse Wolgamott

[email protected]:

Hmm, but there are more spec files than the message_board_spec, right?

On Tue, Mar 4, 2014 at 2:38 PM, Adam Lowe [email protected]
wrote:

rspec message_board_spec.rb
..
Top 2 slowest examples (0.00072 seconds, 100.0% of total time):
MessageBoard should tell the engineer to slow down
0.00045 seconds ./message_board_spec.rb:9
MessageBoard should confirm to the conductor that it slowed down
0.00027 seconds ./message_board_spec.rb:14
Finished in 0.00123 seconds
2 examples, 0 failures
Randomized with seed 6127
On Tue, Mar 4, 2014 at 11:32 AM, Jesse Wolgamott
[email protected]:

so, the specs are still failing for me. Are they passing for you?

Reply to this email directly or view it on GitHub<

#11 (comment)

.


Reply to this email directly or view it on GitHub:

#11 (comment)

Reply to this email directly or view it on GitHub<
#11 (comment)

.

Reply to this email directly or view it on GitHubhttps://github.com//pull/11#issuecomment-36665314
.

Jesse Wolgamott @ Comal Productions
Web. Mobile. Training. Code.

http://comalproductions.com
Twitter: @jwo
713.234.0361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants