Tiger level challenge #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion of movie_json.rb
…mmer2012 to change commit message
| class Api | ||
|
|
||
| APIKEY="4t6456xa33z8qhcqyuqgnkjh" | ||
| APIKEY=API_KEY |
There was a problem hiding this comment.
I like the moving the key into a git-ignored file. But, you can just have that set your variable... in api_key.rb have it set APIKEY directly. This line ends up looking odd (and future-you won't remember what this is)
|
Great job on the specs! And I really love the thought of security with the gitignore. Let me know if you have any questions on my comments :) |
…d add to movie list methods. fix specs
… and movie_rating_slope methods
|
Tried to fix the things you suggested, let me know if this looks better! Thanks |
| year: struct.year, | ||
| score: struct.ratings["critics_score"] | ||
| ) | ||
| struct.id.nil? ? NullObject.new : store_movie(struct) |
There was a problem hiding this comment.
Looks great!!
Only comment: rather than "store_movie", recommend "build_movie". Store tends to imply persistence.
|
Looks greast! Significant improvement in readability. yay! |
|
👍 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the api_key with mine from a .gitignore file, FYI. Also, 1 question, in movie_json.rb #movie_search_by_title is complicated. Is this best fixed with more, simpler, methods? Thanks!