Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make-dist support and github workflow #9

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bandoti
Copy link

@bandoti bandoti commented Jul 1, 2024

This change adds a new github workflow for generating a distribution tarball containing required sub-modules, fixing #6 .

In addition, it fixes some build issues with MSYS2 related to header files referenced as symbolic links.

@bandoti
Copy link
Author

bandoti commented Nov 7, 2024

@cyanogilvie

The make-dist support is working now. Please note that I had to remove the symlink behavior which tcl-tomlcrypt uses in order to be able to support the tarballs on MSYS2, as Windows does not play nicely with symlinks. In particular:

  • Delete Makefile.teabase.in

  • Modify Makefile.in to use path relative to builddir:
    include $(top_builddir)/teabase/Makefile

  • Modify configure.ac to add teabase include path and reference teabase/Makefile directly:

    TEA_ADD_INCLUDES([-I$srcdir/teabase])
    ...
    
    AC_CONFIG_FILES([Makefile pkgIndex.tcl teabase/Makefile])
    

Another thing to note is that the action permissions had to be adjusted, and the token set, to allow pushes to the release:

    permissions:
      contents: write
  token: ${{ secrets.GITHUB_TOKEN }}

If you are happy with this change, I would be happy to make the similar changes to tcl-tomlcrypt supporting MSYS2. Also note I have the CI run and generated test release here:
https://github.com/TclMonster/parse_args/actions/runs/11730151951
https://github.com/TclMonster/parse_args/releases/tag/v0.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant