Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress.yaml #2

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Update ingress.yaml #2

merged 3 commits into from
Dec 19, 2023

Conversation

rocket357
Copy link
Contributor

@rocket357 rocket357 commented Dec 17, 2023

ingressClassName ignored when installing rubxkube/gotify with isIngressRoute: false.

Chart Addition Pull Request

Name: common-charts
version: 0.2.0
tests:

  • classicHttp
  • curlHostHeader

Additional Information

Please provide any additional information or context about this chart addition.

Checklist

Please review and check the following before submitting this pull request:

  • I have tested the chart locally and it works as expected.
  • I have included a valid Chart.yaml file with the required information.
  • I have documented the usage and configuration options of the chart in the README.md file.
  • I have included any necessary dependencies and mentioned them in the README.md file.
  • I have considered security best practices while creating the chart.

Screenshots or Examples (if applicable)

If relevant, please provide any screenshots or examples demonstrating the usage or functionality of the chart.

Related Issues

Closes #<issue_number>

Please mention any related issues that will be resolved or enhanced by this chart addition.

Reviewers

@, @

Please tag relevant reviewers who should review this pull request.

ingressClassName ignored when installing rubxkube/gotify.
Also add missing certResolver annotation to ingress template.
@qjoly
Copy link
Member

qjoly commented Dec 19, 2023

Thanks a lot for your PR :)

@qjoly qjoly merged commit 5d829f6 into RubxKube:main Dec 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants