Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insert -- between RSH and rsync commands #656

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −0
Open

feat: insert -- between RSH and rsync commands #656

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59d95cf
feat: insert `--` between RSH and rsync commands
TheoTechnicguy Oct 28, 2024
b9e5f07
Merge branch 'master' into feat/rsh-rsync-flag-split
TheoTechnicguy Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,10 @@ static pid_t do_cmd(char *cmd, char *machine, char *user, char **remote_argv, in
args[argc++] = machine;
#endif

// include a `--` before any rsync commands to indicate that
// all following arguments are intended as positional
// and should not be parsed by the shell
args[argc++] = "--";
args[argc++] = rsync_path;

if (blocking_io < 0 && (strcmp(t, "rsh") == 0 || strcmp(t, "remsh") == 0))
Expand Down