Return from #list command with 0 #639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "#list" command should not be treated as a failure when it is both a legitimate request by the client, and correctly answered by the server. It is commonly used for assessing whether a rsync endpoint is healthy, having it return with a non-zero exit code causes misleading error reports, and, in case of socket activation, failed service instances on the server. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
|
what testing has been done? Have you tested both inetd operation and running as a daemon? |
|
I tested running through a socket activated systemd service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "#list" command should not be treated as a failure when it is both a legitimate request by the client, and correctly answered by the server. It is commonly used for assessing whether a rsync endpoint is healthy, having it return with a non-zero exit code causes misleading error reports, and, in case of socket activation, failed service instances on the server.