Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: fix failing IPv6 check due to missing return type #558

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Jan 2, 2024

Fixing this warning escalated to an error, resuting in no IPv6 support:

configure.sh:7679: checking whether to enable ipv6
configure.sh:7718: clang -o conftest -g -O2 -DHAVE_CONFIG_H -Wall -W   conftest.c  >&5
conftest.c:73:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
main()
^
int
1 error generated.
configure.sh:7718: $? = 1
configure.sh: program exited with status 1

@bobrik
Copy link
Contributor Author

bobrik commented Jan 2, 2024

It was a warning on clang-15, but it is an error on clang-16:

@bobrik
Copy link
Contributor Author

bobrik commented Jan 2, 2024

A similar thing happened to curl: curl/curl#12607

@bobrik
Copy link
Contributor Author

bobrik commented Jan 2, 2024

I'm happy to pull the curl's version verbatim if you think that's better.

Fixing this warning escalated to an error, resuting in no IPv6 support:

```
configure.sh:7679: checking whether to enable ipv6
configure.sh:7718: clang -o conftest -g -O2 -DHAVE_CONFIG_H -Wall -W   conftest.c  >&5
conftest.c:73:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
main()
^
int
1 error generated.
configure.sh:7718: $? = 1
configure.sh: program exited with status 1
```
@tridge
Copy link
Member

tridge commented Apr 6, 2024

@bobrik looks good, thanks!

@tridge tridge merged commit 0dd25d4 into RsyncProject:master Apr 6, 2024
3 checks passed
@bobrik bobrik deleted the ivan/int-main branch June 2, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants