Make size related variables and outputs size_t #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Apr 6, 2024
|
|
||
| #ifdef HAVE_OSX_ACLS | ||
| /* If we received a superfluous mask, throw it away. */ | ||
| duo_item->racl.mask_obj = NO_ENTRY; | ||
| (void)mode; | ||
| #else | ||
| if (flags & XMIT_NAME_LIST) |
There was a problem hiding this comment.
this change looks like it will change the wire protocol if HAVE_OSX_ACLS is defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sense for these values that are expected to be unsigned to be treated as such, especially on 64 bit platforms where we can avoid the cost of truncation by only doing it when needed, as opposed to every time strlen returns a value