Issue #3186: Enable Lens DF to use Reference DF as attribute field #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanhaerter
force-pushed
the
issue-#3186-setsdynamiccontent
branch
2 times, most recently
from
0caa8f1
to
40411ed
Compare
| @@ -289,7 +289,7 @@ sub ObjectDataGet { | |||
| Param => 'TicketID', | |||
| ); | |||
|
|
|||
| return if !$TicketID; | |||
| return unless $TicketID; | |||
There was a problem hiding this comment.
Cool, ich bin ein Fan von 'return unless'
There was a problem hiding this comment.
You got me hooked on that 😁
stefanhaerter
force-pushed
the
issue-#3186-setsdynamiccontent
branch
2 times, most recently
from
211644a
to
11feedc
Compare
stefanhaerter
force-pushed
the
issue-#3186-setsdynamiccontent
branch
2 times, most recently
from
31acbe5
to
01ab40a
Compare
stefanhaerter
force-pushed
the
issue-#3186-setsdynamiccontent
branch
from
01ab40a
to
5432085
Compare
stefanhaerter
force-pushed
the
issue-#3186-setsdynamiccontent
branch
2 times, most recently
from
e82c7c7
to
081f30a
Compare
…if they are present.
stefanhaerter
force-pushed
the
issue-#3186-setsdynamiccontent
branch
from
9c5572c
to
1974050
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also another small bugfix and a readability enhancement.
Referencing #3186.