Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to follow rlf and other fixes #11

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Update to follow rlf and other fixes #11

merged 1 commit into from
Jan 2, 2025

Conversation

alihamdan
Copy link
Member

Copy changes made in rlf, fixes, and enhancements.

Fixes:

  • Fix wrong transformer parameters when updating tap or parameters. It was using the wrong z2, ym and k
  • Fix network frames missing newely added fields like nominal_voltage, loading, etc in addition to missing tap for transformers
  • Fix voltage_level not set for en.res_buses if voltage limits are not defined but nominal voltage is defined
  • Add missing full results such as voltage_level for buses, loading for lines and transformers
  • Add missing line_type setter on line parameters similar to material and insulator
  • Fix slow res_violated for transformers using the same trick used for lines earlier
  • Fix links in docstring to point to rlfs classes instead of rlf classes
  • Fix type annotations to use broad types for inputs (union defined aliases like Float) and narrower types for outputs (like float). Add missing | Q_[] in some places.

Enhancements:

  • Add top-level types module from rlf
  • Add SQRT3 constant from rlf
  • Use faster coverage in CI
  • Copy improved error messages from rlf for the case of a singular matrix
  • Improve tests of electrical network
  • Use precise typing for cy elements

@alihamdan alihamdan added bug Something isn't working enhancement New feature or request labels Jan 2, 2025
@alihamdan alihamdan self-assigned this Jan 2, 2025
@alihamdan alihamdan merged commit 45fc3e9 into develop Jan 2, 2025
5 checks passed
alihamdan added a commit that referenced this pull request Jan 2, 2025
@alihamdan alihamdan deleted the update branch January 2, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant