Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make internal class attributes private #105

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Make internal class attributes private #105

merged 1 commit into from
Jul 28, 2023

Conversation

alihamdan
Copy link
Member

We already did this for the load classes but forgot the others on the network and flexible parameters.

@alihamdan
Make internal class attributes private
c9fdf6d 
We already did this for the load classes but forgot the
others on the network and flexible parameters.
@alihamdan alihamdan added the enhancement New feature or request label Jul 28, 2023
@alihamdan alihamdan self-assigned this Jul 28, 2023
benoit9126
benoit9126 approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@benoit9126 benoit9126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It should also be changed in the engine.

@alihamdan
Copy link
Member Author

+1 It should also be changed in the engine.

I have a commit ready, just waiting for this to be merged

@alihamdan alihamdan merged commit 503891b into develop Jul 28, 2023
4 checks passed
@alihamdan alihamdan deleted the internal branch July 28, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoit9126 benoit9126 benoit9126 approved these changes

Assignees

@alihamdan alihamdan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alihamdan @benoit9126