RK-20397 - [DOB-490] fix old electron #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ron-rookout
previously approved these changes
Apr 7, 2024
ron-rookout
approved these changes
Apr 7, 2024
|
Github Enforcer opened Task: RK-20397 |
sonariorobot
changed the title
Urook
suggested changes
Apr 8, 2024
| @@ -100,7 +100,7 @@ | |||
| "aws-lambda": "^1.0.5", | |||
| "copyfiles": "^2.3.0", | |||
| "cross-env": "^5.2.0", | |||
| "electron": "22.3.12", | |||
| "electron": "26.6.10", | |||
There was a problem hiding this comment.
@FridmasterDyna
Did you make sure you addressed all breaking changes?
https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-260
| @@ -100,7 +100,7 @@ | |||
| "aws-lambda": "^1.0.5", | |||
| "copyfiles": "^2.3.0", | |||
| "cross-env": "^5.2.0", | |||
| "electron": "22.3.12", | |||
| "electron": "26.6.10", | |||
There was a problem hiding this comment.
@FridmasterDyna
Also, this will auto update explorook for a few users and will break their epxplorook app
I recommend, at least, releasing a version that uses electron 22 and does not auto update, and inform those users they need to use that version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update electron version