Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for std::string_view #36

Merged
merged 1 commit into from
May 16, 2024

Conversation

elrinor
Copy link
Contributor

@elrinor elrinor commented May 6, 2024

This is a saner way to query ini values w/o copying the strings around for us people living in 2024.

Changes:

  • Added Convert<std::string_view> specialization, conditional on std::string_view being available.
  • Added tests for it.
  • Running GH tests in C++11 and C++17 modes.

@Rookfighter
Copy link
Owner

Hi @elrinor,
thanks for your contribution and sorry for my late reply. Looks really good to me, thanks again for the great and sophisticated contribution. No findings, approved 👍

@Rookfighter Rookfighter merged commit 8895335 into Rookfighter:master May 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants