refactor: list_exists rules #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenTray
requested changes
Dec 23, 2024
src/HelpersServiceProvider.php
Outdated
| return false; | ||
| } | ||
|
|
||
| $table = Arr::get($parameters, 0); | ||
| $keyField = Arr::get($parameters, 1, 'id'); | ||
|
|
||
| if (!empty(Arr::get($parameters, 2))) { | ||
| $tableFields = DB::getSchemaBuilder()->getColumnListing($table); |
There was a problem hiding this comment.
it's not good, to get table data inside the validation rule, let's keep this case without user readable error
src/HelpersServiceProvider.php
Outdated
| } | ||
| } | ||
|
|
||
| if ($isExistsParam) { |
There was a problem hiding this comment.
let's rename this var to hasFieldNameParam
DenTray
requested changes
Dec 25, 2024
src/HelpersServiceProvider.php
Outdated
| if (count($parameters) < 1) { | ||
| $validator->errors()->add($attribute, 'You must add at least 1 parameter'); |
There was a problem hiding this comment.
I've checked it one more time and it's not good to fail validation in case the developer use validation rule incorrectly. Let's implement the separate InvalidValidationRuleUsageException for such cases
| result: [[ 'aggregate' => count($result) ]], | ||
| bindings: [1, 2, 3], | ||
| ); | ||
| DB::shouldReceive('table') |
There was a problem hiding this comment.
any reasons to mock DB facade instead of asserting SQL?
DenTray
requested changes
Dec 25, 2024
| @@ -3,6 +3,7 @@ | |||
| namespace RonasIT\Support\Tests\Support\Traits; | |||
|
|
|||
| use Illuminate\Support\Carbon; | |||
| use Illuminate\Support\Facades\DB; | |||
There was a problem hiding this comment.
Suggested change
| use Illuminate\Support\Facades\DB; |
DenTray
approved these changes
Dec 26, 2024
DenTray
approved these changes
Dec 26, 2024
DenTray
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77 (comment)