Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setModulatorValue: make "ui" flag working again, because MIDIbox pane… #573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

setModulatorValue: make "ui" flag working again, because MIDIbox pane… #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Core/CtrlrModulator/CtrlrModulatorProcessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void CtrlrModulatorProcessor::handleAsyncUpdate()
owner.setProperty (Ids::modulatorValue, currentValue.value);
}

if (valueChangedCbk.get() && !owner.getRestoreState())
if (valueChangedCbk.get() && !owner.getRestoreState() && currentValue.lastChangeSource != CtrlrModulatorValue::changedByProgram)
{
CtrlrPanel &ownerPanel = owner.getOwnerPanel();
if (!ownerPanel.getRestoreState() && !ownerPanel.getBootstrapState() && valueChangedCbk->isValid())
Expand Down
2 changes: 1 addition & 1 deletion Source/Lua/CtrlrLuaManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ void CtrlrModulator::setValueNonMapped (const int newValue, const bool force, co

void CtrlrModulator::setModulatorValue(const int newValue, bool vst, bool midi, bool ui)
{
processor.setValueGeneric (CtrlrModulatorValue (newValue, CtrlrModulatorValue::changedByLua), true, !midi);
processor.setValueGeneric (CtrlrModulatorValue (newValue, ui ? CtrlrModulatorValue::changedByProgram : CtrlrModulatorValue::changedByLua), true, !midi);
}

int CtrlrModulator::getValueMapped() const
Expand Down