Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve macos disk image background #763

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve macos disk image background #763

wants to merge 1 commit into from

Conversation

williamchange
Copy link
Contributor

@williamchange williamchange commented Mar 2, 2025 •
edited
Loading

Improve labels legibility in disk image for the mac os build and fix background position/scaling

Before / After:
disk_image_preview

Calinou
Calinou approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting solution to the problem, but if we can't change the text color ourselves, it's the best we can do.

@williamchange
Copy link
Contributor Author

change the text color

Probably not possible. I think most dmg's I came across either use a light image background or no background at all (which then the labels would be black/white depending on the system's light/dark theme setting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamchange @Calinou