Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix other themes #710

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Fix other themes #710

merged 4 commits into from
Oct 23, 2024

Conversation

Jowan-Spooner
Copy link
Contributor

  • Removes most of the old themes
  • Renames "Modern" to "Default Dark"
  • Recreates the "Classic" theme
  • Adds a simple theme-variant system
    • Creates a "Default Light" theme variant of the Default Dark theme

ToDo:

  • follow up Icons PR, where all icons are replaced with a single svg icon sheet.
  • Some more cleanup in the themes folder
  • Possibly implement theme-scaling as an alternative to content_scale scaling.

@Jowan-Spooner Jowan-Spooner mentioned this pull request Oct 23, 2024
@RodZill4 RodZill4 added this to the 1.4 milestone Oct 23, 2024
@RodZill4 RodZill4 merged commit a966230 into RodZill4:master Oct 23, 2024
2 checks passed
@Calinou
Copy link
Contributor

Calinou commented Oct 24, 2024

Possibly implement theme-scaling as an alternative to content_scale scaling.

Out of curiosity, why is that needed? godotengine/godot#86022 should make a custom approach unnecessary once it's merged, as it'll be possible to easily use hiDPI-friendly icons out of the box.

@Jowan-Spooner
Copy link
Contributor Author

@Calinou Yeah, I know, I would love to use that. But it's been stale for another half year. I'll try to keep my workarounds easily undoable because of course the built-in solution would be best, but it's just not there yet. So I will create workarounds until then. Rod has considered removing the multi-window support because of how buggy scaling is with sub-windows and I think that would be a real bummer, so I've been experimenting with alternative ways to get better scaling. Anyways the theme-scaling isn't in this PR anyways, it's just something that could be possible with this approach.

Also this has other benefits, such as recoloring icons, which isn't possible otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants