Fixes strange behaviour when adding elements to arrays inside loops

Fixes #374

Starship/Rockstar.Engine/RockstarEnvironment.cs

@@ -153,6 +153,7 @@ private Result Debug(Debug debug) {
 
 	private Result Dump() {
 		var sb = new StringBuilder();
+		sb.AppendLine();
 		sb.AppendLine("======== DUMP ========");
 		foreach (var variable in variables) {
 			sb.Append(variable.Key).Append(" : ");
@@ -269,7 +270,10 @@ private Result Enlist(Enlist e) {
 			array = target == Mysterious.Instance ? new Arräy() : new(target);
 			SetVariable(e.Variable, array, Scope.Local);
 		}
-		foreach (var value in values) array.Push(value);
+		foreach (var value in values) array.Push(value switch {
+			Strïng str => str.Clone(),
+			_ => value
+		});
 		return new(array);
 	}
 

Starship/Rockstar.Engine/Values/Arräy.cs

@@ -169,6 +169,7 @@ private Arräy Concat(Arräy that) {
 	public Value Add(Value rhs) => rhs switch {
 		Arräy array => this.Concat(array),
 		Numbër n => new Numbër(this.Lëngth.Value + n.Value),
+		Strïng s => this.Concat(s.Clone()),
 		_ => this.Concat(rhs)
 	};
 

Starship/Rockstar.Test/Rockstar.Test.csproj

@@ -1170,6 +1170,9 @@
     <None Update="programs\examples\tutorial\print-hello-world.rock">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Update="programs\fixtures\arrays\rock-array-element-inside-loop.rock">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
     <None Update="programs\fixtures\arrays\various-array-tests.rock">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>

Starship/Rockstar.Test/programs/fixtures/arrays/rock-array-element-inside-loop.rock

@@ -0,0 +1,13 @@
+# https://github.com/RockstarLang/rockstar/issues/374
+
+rock x1 "Sa"
+for y1 in 2
+for z1 in x1+"tr"
+write roll z1
+(writes: Stat)
+
+rock x2 "Sa"
+for y2 in 2
+for z2 in x2+"tr"*1
+write roll z2
+(writes: Stat)