Skip to content

Commit

Permalink
Merge pull request #143 from RocketChat/feat-serve-wellknown-natively
Browse files Browse the repository at this point in the history
feat: serve well-known paths for federation natively
  • Loading branch information
debdutdeb authored May 20, 2024
2 parents 91672ed + a08b617 commit df720a1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
8 changes: 8 additions & 0 deletions rocketchat/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -309,3 +309,11 @@ Refernces:
- [Run a shell inside a container (to check mongodb version)](https://kubernetes.io/docs/tasks/debug/debug-application/get-shell-running-container/)
- [MongoDB upgrade official documentation](https://www.mongodb.com/docs/manual/tutorial/upgrade-revision/)
- [MongoDB helm chart options](https://artifacthub.io/packages/helm/bitnami/mongodb)

### To 6.13.0

**This is only applicable if you both, enabled federation in chart version >=6.8, and want to keep using lighttpd.**

IFF you manually enabled ingress.federation.serveWellKnown (which was a hidden setting) before, during upgrade, disable it once before enabling it again.

Chart contained a bug that would cause `wellknown` deployment to fail to update (illegal live modification of `matchLables`).
4 changes: 0 additions & 4 deletions rocketchat/templates/lighttpd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,12 @@ spec:
selector:
matchLabels:
app.kubernetes.io/name: {{ include "rocketchat.fullname" . }}-wellknown
helm.sh/chart: {{ include "rocketchat.chart" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
template:
metadata:
labels:
app.kubernetes.io/name: {{ include "rocketchat.fullname" . }}-wellknown
helm.sh/chart: {{ include "rocketchat.chart" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
spec:
containers:
- name: lighttpd
Expand Down
2 changes: 1 addition & 1 deletion rocketchat/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ ingress:
# hosts:
# - chart-example.local
federation:
serveWellKnown: true # if false, rocket.chat will handle the response
serveWellKnown: false

service:
annotations: {}
Expand Down

0 comments on commit df720a1

Please sign in to comment.