Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace Menu in favor of GenericMenu in RoomMenu #34927

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jan 9, 2025

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

ARCH-1405

Copy link
Contributor

dionisio-bot bot commented Jan 9, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 5e8954a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 15, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34927/

Built to branch gh-pages at 2025-01-17 04:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (c75d771) to head (5e8954a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34927      +/-   ##
===========================================
+ Coverage    59.12%   59.18%   +0.05%     
===========================================
  Files         2819     2819              
  Lines        67856    67719     -137     
  Branches     15115    15081      -34     
===========================================
- Hits         40123    40077      -46     
+ Misses       24905    24819      -86     
+ Partials      2828     2823       -5     
Flag Coverage Δ
unit 75.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 7.3.0 milestone Jan 16, 2025
@dougfabris dougfabris marked this pull request as ready for review January 16, 2025 18:34
@dougfabris dougfabris requested review from a team as code owners January 16, 2025 18:34
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jan 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 16, 2025
@tassoevan tassoevan merged commit f7f35c3 into develop Jan 17, 2025
49 checks passed
@tassoevan tassoevan deleted the refactor/room-menu branch January 17, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants