Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds Gitpod Flex support #34916

Merged
merged 7 commits into from
Jan 21, 2025
Merged

chore: adds Gitpod Flex support #34916

merged 7 commits into from
Jan 21, 2025

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Jan 9, 2025

Proposed changes (including videos or screenshots)

As per CORE-923, this PR introduces support for running workspaces on Gitpod Flex, the new platform replacing Gitpod Classic, which is scheduled to be discontinued by April 2025.

Additionally, it includes a devcontainer configuration that addresses issues with loading NVM, Deno, and Meteor. These tools were previously problematic when using the .gitpod.yml configuration.

Issue(s)

Steps to test or reproduce

Further comments

  • The .gitpod.yml file remains available for backward compatibility with Gitpod Classic, which will continue to operate until April 2025.
  • For new workspaces, the recommended approach is to use devcontainer files along with Gitpod automation configurations for better compatibility and future-proofing.

Copy link
Contributor

dionisio-bot bot commented Jan 9, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 9efda02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34916/

Built to branch gh-pages at 2025-01-20 19:51 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.20%. Comparing base (5ab0c52) to head (9efda02).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34916      +/-   ##
===========================================
+ Coverage    59.17%   59.20%   +0.02%     
===========================================
  Files         2822     2820       -2     
  Lines        68127    67297     -830     
  Branches     15149    14987     -162     
===========================================
- Hits         40316    39844     -472     
+ Misses       24979    24648     -331     
+ Partials      2832     2805      -27     
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim marked this pull request as ready for review January 10, 2025 09:28
@MarcosSpessatto MarcosSpessatto added this to the 7.3.0 milestone Jan 10, 2025
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Jan 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@MarcosSpessatto MarcosSpessatto modified the milestones: 7.3.0, 7.4.0 Jan 20, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 20, 2025
@kodiakhq kodiakhq bot merged commit 4e911b4 into develop Jan 21, 2025
49 checks passed
@kodiakhq kodiakhq bot deleted the chore/gitpod-flex branch January 21, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants