Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove calls for setEmail Meteor method (server) #34889

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MarcosSpessatto
Copy link
Member

https://rocketchat.atlassian.net/browse/CORE-913

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 6, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@MarcosSpessatto MarcosSpessatto added this to the 7.3.0 milestone Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34889/
on branch gh-pages at 2025-01-07 15:43 UTC

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (fc89745) to head (6356e93).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #34889    +/-   ##
=========================================
  Coverage    59.17%   59.18%            
=========================================
  Files         2821     2821            
  Lines        68143    67593   -550     
  Branches     15154    15044   -110     
=========================================
- Hits         40327    40006   -321     
+ Misses       24981    24773   -208     
+ Partials      2835     2814    -21     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 6356e93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review January 7, 2025 16:16
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner January 7, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant