-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve links readability #5856
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw these changes on MA-74 too, I was planning to ship these with the other task. |
Are you sure? I was not able to find them there. |
Yes, it was in the designs for that other task too. No worries, let me do these with this task itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yash-rajpal Hey Yash. Please take a look at the recent commits I did to display how some small changes affect the overall code readability, composability and UX :)
Please start using gap instead of margins. This is not present on the rest of the app, because it was introduced recently on a recent release of React Native. We're going to start migrating to this new way of composing components in baby steps, like this PR.
Also please make sure to check text fonts again. This is a accessibility project and small details matter 🤞🏼
Let me know if you need help understanding new gap style, Figma or just need some tips. We can pair program through this.
Thanks!
Thanks Diego, I'll check these and keep them in mind. I'll reach out to you if I have any doubts. |
eeffaba
to
131e1cc
Compare
Proposed changes
Moving the TnC links on login and sign up pages in new lines for better readability by on screen readers.
Issue(s)
How to test or reproduce
Screenshots
Before
After
Types of changes
Checklist
Further comments
MA-76