Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve links readability #5856

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Sep 5, 2024

Proposed changes

Moving the TnC links on login and sign up pages in new lines for better readability by on screen readers.

Issue(s)

How to test or reproduce

Screenshots

Before

image

After

image
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

MA-76

@yash-rajpal yash-rajpal marked this pull request as ready for review September 5, 2024 15:07
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing these changes

image

@yash-rajpal
Copy link
Member Author

yash-rajpal commented Sep 5, 2024

I saw these changes on MA-74 too, I was planning to ship these with the other task.

@diegolmello
Copy link
Member

diegolmello commented Sep 6, 2024

I saw these changes on MA-74 too, I was planning to ship these with the other task.

Are you sure? I was not able to find them there.

@yash-rajpal yash-rajpal removed the request for review from diegolmello September 9, 2024 09:07
@yash-rajpal
Copy link
Member Author

Yes, it was in the designs for that other task too.

No worries, let me do these with this task itself.

Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yash-rajpal Hey Yash. Please take a look at the recent commits I did to display how some small changes affect the overall code readability, composability and UX :)

Please start using gap instead of margins. This is not present on the rest of the app, because it was introduced recently on a recent release of React Native. We're going to start migrating to this new way of composing components in baby steps, like this PR.

Also please make sure to check text fonts again. This is a accessibility project and small details matter 🤞🏼

Let me know if you need help understanding new gap style, Figma or just need some tips. We can pair program through this.

Thanks!

@yash-rajpal
Copy link
Member Author

Thanks Diego, I'll check these and keep them in mind. I'll reach out to you if I have any doubts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants